-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix version.go (Rollback to only use OCCoreSemVer
)
#348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnasu
force-pushed
the
main-fix-version
branch
3 times, most recently
from
November 29, 2021 07:16
9e5424b
to
3e79e20
Compare
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
==========================================
- Coverage 63.02% 62.93% -0.09%
==========================================
Files 272 272
Lines 30253 30253
==========================================
- Hits 19068 19041 -27
- Misses 9459 9480 +21
- Partials 1726 1732 +6
|
tnasu
force-pushed
the
main-fix-version
branch
from
November 29, 2021 07:42
3e79e20
to
16b943b
Compare
torao
added
the
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
label
Nov 29, 2021
torao
approved these changes
Nov 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kynea0b
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C: enhancement
Classification: New feature or its request, or improvement in maintainability of code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
version.go
does not work correctry. I fix to only useOCCoreSemVer
.github.event.repository.default_branch
): 375b1aeversion.go
): 26c9b0cAppendix
How to set
version.go:OCCoreSemVer
How to get
VERSION
from git the version