-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change default iavl-cache-size
#666
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zemyblue <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #666 +/- ##
==========================================
- Coverage 60.45% 60.42% -0.04%
==========================================
Files 826 826
Lines 96128 96128
==========================================
- Hits 58111 58082 -29
- Misses 34514 34560 +46
+ Partials 3503 3486 -17
|
Signed-off-by: zemyblue <[email protected]>
dudong2
approved these changes
Sep 7, 2022
0Tech
reviewed
Sep 8, 2022
apply feedback Co-authored-by: Youngtaek Yoon <[email protected]>
0Tech
approved these changes
Sep 8, 2022
This was referenced Sep 20, 2022
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change default
iavl-cache-size
of config.Default real iavl cache size set 128MB.
So I set the
DefaultIAVLCacheSize = 1048576
.Motivation and context
The iavl cach size of config is different with real cache size.
The config setting size is the number of iavl cache unit. And 1 iavl cache unit is 128byte struct according to cosmos/cosmos-sdk#10561 (comment)
So current default iavl cache size is so big.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml