Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after loading the reference list #31

Open
Varun-Mayilvaganan opened this issue Aug 21, 2024 · 5 comments
Open

after loading the reference list #31

Varun-Mayilvaganan opened this issue Aug 21, 2024 · 5 comments

Comments

@Varun-Mayilvaganan
Copy link

Varun-Mayilvaganan commented Aug 21, 2024

Screenshot (38)
Screenshot (39)

@lindsey98
Copy link
Owner

Hi,
you need to move everything under expand_targetlist/expand_targetlist to expand_targetlist/, such that there is no nested directories.

@Varun-Mayilvaganan
Copy link
Author

Eventhough it runs perfect but the functionality is not working
i took 6 fake websites and url but it shows legit

WhatsApp Image 2024-08-23 at 12 30 45 AM (1)

@lindsey98
Copy link
Owner

It seems that the logo matching confidence (0.64, 0.65 ...) is far from the threshold.
I suspect the top-1 logo reported is not the identity logo.
So you can try to change https://github.com/lindsey98/Phishpedia/blob/main/phishpedia.py#L102, set top_k=3 for example to iterate over top-3 logos.

@Varun-Mayilvaganan
Copy link
Author

Hi lindsey98,
I tried it but no change in the result

@lindsey98
Copy link
Owner

I visited some of the pages https://intsa.vercel.app/, https://www.wal-mart.com/, and I found our reference list didn't protect similar logos as the ones shown on the webpage. For the Instagram phishing, they didn't use the official logo of Instagram. For the Walmart phishing, the logo shown on the webpage is in blue background but our reference list only keeps the white background. You can do the following to expand the target list:

  1. Delete the LOGO_FILES.npy and LOGO_FEATS.npy
  2. Manually add similar logo images to expand_targetlist/Instagram or expand_targetlist/walmart
  3. Rerun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants