Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup linter #3

Closed
MichaelBailly opened this issue Nov 5, 2020 · 3 comments · Fixed by #13
Closed

Setup linter #3

MichaelBailly opened this issue Nov 5, 2020 · 3 comments · Fixed by #13
Assignees
@alagane @oubchid

Comments

@MichaelBailly
Copy link

Setup a linter to ensure a consistent code style.
@alagane
Copy link
Member

alagane commented Jan 11, 2021 •
edited
Loading

Husky https://github.com/typicode/husky could also be added to ensure formatting and linting is ok before committing/pushing.

@oubchid
Copy link

oubchid commented Jan 13, 2021 •
edited
Loading

We could also use ESLint rather than TSLint (TSLint has been the recommended linter in the past but now TSLint is deprecated and ESLint is taking over its duties)
palantir/tslint#4534
https://code.visualstudio.com/api/advanced-topics/tslint-eslint-migration
microsoft/TypeScript#29288 (comment)

oubchid pushed a commit to oubchid/jmap-client-ts that referenced this issue Jan 14, 2021
linagora#3 Migrate to ESlint and code formatting using prettier and h…
56587e8 
…uskey
oubchid pushed a commit to oubchid/jmap-client-ts that referenced this issue Jan 14, 2021
linagora#3 Migrate to ESlint and code formatting using prettier and h…
9c4edf8 
…uskey
oubchid pushed a commit to oubchid/jmap-client-ts that referenced this issue Jan 14, 2021
linagora#3 Migrate to ESlint and code formatting using prettier and h…
c4e0655 
…uskey
oubchid pushed a commit to oubchid/jmap-client-ts that referenced this issue Jan 14, 2021
linagora#3 Migrate to ESlint and code formatting using prettier and h…
d10865e 
…uskey
oubchid pushed a commit to oubchid/jmap-client-ts that referenced this issue Jan 14, 2021
linagora#3 Migrate to ESlint and code formatting using prettier and h…
5996aa7 
…usky
@alagane
Copy link
Member

alagane commented Jan 18, 2021

Related merge request: #13

alagane added a commit that referenced this issue Jan 19, 2021
@alagane
Merge pull request #13 from oubchid/jmap_ts-3-migrate-to-eslint-code-…
2e6fdc9 
…formatting

#3 Migrate to ESlint and code formatting using prettier and husky
@oubchid oubchid linked a pull request Jan 21, 2021 that will close this issue
#3 Migrate to ESlint and code formatting using prettier and husky #13
Merged
@oubchid oubchid closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alagane alagane

@oubchid oubchid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3 Migrate to ESlint and code formatting using prettier and husky oubchid/jmap-client-ts
3 participants
@alagane @MichaelBailly @oubchid