Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved tuning parameters on Windows #238

Closed
kaorahi opened this issue Jun 3, 2020 · 10 comments
Closed

Saved tuning parameters on Windows #238

kaorahi opened this issue Jun 3, 2020 · 10 comments

Comments

@kaorahi
Copy link
Contributor

kaorahi commented Jun 3, 2020

I received a bug report
kaorahi/lizgoban#53
and noticed that HomeData::getHomeDataDir was changed in f659e5d (v1.3.4).

In the all-in-one package
https://github.com/kaorahi/lizgoban/releases/tag/v0.5.0-pre1
of my GUI, katago.exe is extracted into a temporary directory that is removed after every run. This will cause the initial tuning of KataGo in every run, I guess. (I have no Windows machine and cannot test it by myself.)

For old getHomeDataDir, I set the current directory as a permanent place (the directory containing LizGoban*.exe itself) to avoid this problem. What can I do for new getHomeDataDir?

If possible, I would like to keep offering a single binary of my GUI that works without installation and additional downloads for those who are not familiar with computers.

@lightvector
Copy link
Owner

Would it be good if I added an option in the config to specify the directory? If so, I will do that for next release.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 3, 2020

Yes. I would be happy if you would add that option in 1.4.3. I cannot fix this problem in GUI side and my package is practically unusable for CPU-only users until it.

@sente361
Copy link

sente361 commented Jun 4, 2020

In the all-in-one package
https://github.com/kaorahi/lizgoban/releases/tag/v0.5.0-pre1
of my GUI, katago.exe is extracted into a temporary directory that is removed after every run. This will cause the initial tuning of KataGo in every run, I guess. (I have no Windows machine and cannot test it by myself.)

Yes, every time I select Preset/KataGo* it goes through the tuning process. I tried manually creating the folder AppData\Local\Temp\1ccmWyFMOdGhvr5HFTlpN7fNPjm\resources\external\katago/KataGoData/opencltuning/ and copying over the tune6... files that BadukMegapack created a few weeks ago. However it was immediately removed when I tried KataGo afterwards.

@lightvector
Copy link
Owner

Pushed to master:
4a79cde
(if you can compile KataGo you can already use this, else wait for 1.4.3).

Adds homeDataDir = DIRECTORY as option for the config to set where to write the opencl tuning files. Also like other options in the config, it may be also specified/overridden inline on the command line via "-override-config".

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 5, 2020

Thanks for rapid implementation! I will wait for the official binary of 1.4.3 as I do not have Windows.

@sente361
Copy link

sente361 commented Jun 5, 2020

Thanks to both of you. I will wait for the release.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 6, 2020

Can I use -override-config "homeDataDir=." to emulate the behavior of old getHomeDataDir before f659e5d on Windows?

@lightvector
Copy link
Owner

Although I have not actually tested that yet, I think that would work.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 11, 2020

Thanks. I will try it when 1.4.3 is released.

@kaorahi
Copy link
Contributor Author

kaorahi commented Jun 14, 2020

I've heard that -override-config "homeDataDir=." works well in 1.4.3. thx!

@kaorahi kaorahi closed this as completed Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants