Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: add a default value for timeout_seconds in SendPaymentV2 routerrpc.SendPaymentRequest #9282

Open
ZZiigguurraatt opened this issue Nov 19, 2024 · 1 comment
Assignees
Labels
enhancement Improvements to existing features / behaviour good first issue Issues suitable for first time contributors to LND payments Related to invoices/payments

Comments

@ZZiigguurraatt
Copy link

I propose that in the SendPaymentV2 RPC call's routerrpc.SendPaymentRequest that we change the timeout_seconds to have a default value of 60 seconds. Right now, there is no default, so the RPC call results in an error if that field is not populated. Is there a technical reason that timeout_seconds has no default value?

Also, the API docs say timeout_seconds is

An upper limit on the amount of time we should spend when
attempting to fulfill the payment. This is expressed in seconds.
If we cannot make a successful payment within this time
frame, an error will be returned. This field must be non-zero.

However, is this really an "upper limit" if a node along the route stalls for a while during the last payment attempt? Seems like it is more like the time in which the last HTCL will be initiated?

@ZZiigguurraatt ZZiigguurraatt added the enhancement Improvements to existing features / behaviour label Nov 19, 2024
@ziggie1984 ziggie1984 added payments Related to invoices/payments good first issue Issues suitable for first time contributors to LND labels Nov 19, 2024
@kelvinator07
Copy link

@ZZiigguurraatt @ziggie1984 I'd like to work on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour good first issue Issues suitable for first time contributors to LND payments Related to invoices/payments
Projects
None yet
Development

No branches or pull requests

3 participants