Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]: Remove ErrSynchronizingChain from returned error whitelist #7034

Closed
TonyGiorgio opened this issue Oct 13, 2022 · 0 comments · Fixed by #7039
Closed

[feature]: Remove ErrSynchronizingChain from returned error whitelist #7034

TonyGiorgio opened this issue Oct 13, 2022 · 0 comments · Fixed by #7039
Labels
enhancement Improvements to existing features / behaviour needs triage

Comments

@TonyGiorgio
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When investigating the extent of out of sync LND nodes with lnsploit, I noticed that LND will return ErrSynchronizingChain which gives a human readable "Synchronizing blockchain" error when another node attempts to open a channel when the LND node is out of sync.

This gives an attacker the knowledge it needs to know whether or not a malicious unilateral closure (revoked commitment tx broadcast) could succeed if it previously had a channel with that node already.

Describe the solution you'd like
Move or remove ErrSynchronizingChain from the list of errors that will be returned on the wire. This happens here and it should probably fall back to the "funding failed due to internal error" default since that's exactly what it is.

Describe alternatives you've considered
You could keep the error but exclude it from lnwire or you could add more logic around the human readable data that is returned from this error to be more generic.

Additional context
Related: #7002

@TonyGiorgio TonyGiorgio added the enhancement Improvements to existing features / behaviour label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features / behaviour needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants