query: multiple jobs support #303
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing queued jobs to a map allows for multiple job queuing. However the queued jobs is still limited to a single job for now.
kcalvinalvin
force-pushed
the
2024-09-06-multiple-jobs-support
branch
from
b48dffa
to
9c13852
Compare
kcalvinalvin
force-pushed
the
2024-09-06-multiple-jobs-support
branch
from
9c13852
to
4e83c23
Compare
workDispatcher was too long and was hard to read. This change refactors each of the code that handles separate cases so that it's manageable to see what's going on.
A worker is now able to be queried more than 1 job at a time with maxJobs constant introduced to limit the job per peer.
kcalvinalvin
force-pushed
the
2024-09-06-multiple-jobs-support
branch
from
4e83c23
to
0de0038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more efficient querying, it's useful to send multiple jobs to a fast peer if a single peer is much faster than the other.
This PR adds one component to achieve efficient querying: the ability to query multiple jobs.
This PR is incomplete in achieving efficient querying as there's no updates to the peer ranking system. That'll be addressed
in future PRs.