Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose current dust exposure #2264

Open
TheBlueMatt opened this issue May 4, 2023 · 7 comments
Open

Expose current dust exposure #2264

TheBlueMatt opened this issue May 4, 2023 · 7 comments
Labels
good first issue Good for newcomers Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment

Comments

@TheBlueMatt
Copy link
Collaborator

re: #2261 we should also ideally expose what our current dust exposure in a channel is

@TheBlueMatt TheBlueMatt added this to the 0.1 milestone May 4, 2023
@ariard
Copy link

ariard commented May 6, 2023

By exposure do you mean at the counterparty-level or at the network-level? Unclear to me without spec modifications.

@TheBlueMatt
Copy link
Collaborator Author

The dust exposure we have on our current channel which is limited by the config knob.

@ariard
Copy link

ariard commented May 16, 2023

So announce max_dust_htlc_exposure_msat as a new open_channel/accept_channel param or as a new BOLT7 channel_update param ? Or something different ?

@wpaulino
Copy link
Contributor

So announce max_dust_htlc_exposure_msat as a new open_channel/accept_channel param or as a new BOLT7 channel_update param ? Or something different ?

I think this is just meant to expose the current value as part of ChannelDetails.

@TheBlueMatt TheBlueMatt added the Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment label May 6, 2024
@TheBlueMatt TheBlueMatt removed this from the 0.1 milestone May 6, 2024
@TheBlueMatt TheBlueMatt added the good first issue Good for newcomers label May 8, 2024
@acceleratesage
Copy link

Is this still needed after #2442?

@vincenzopalazzo
Copy link
Contributor

vincenzopalazzo commented Oct 10, 2024

@TheBlueMatt
Copy link
Collaborator Author

Well, it wasn't needed, but now it is again....the dust exposure used to just be the sum of dust HTLCs, however in more recent releases it also considers the channel's commitment transaction fee. Ideally we should expose both as a single amount.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Take a Friday Leave a Friday Stomp the Bugs, Without Much Commitment
Projects
None yet
Development

No branches or pull requests

5 participants