Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark grey does not obey contrast ratio #3

Closed
henrebotha opened this issue Mar 2, 2021 · 3 comments
Closed

Dark grey does not obey contrast ratio #3

henrebotha opened this issue Mar 2, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@henrebotha
Copy link

Per the readme:

All colors have a min contrast ratio of 4.5 against the background color.

However, this is not true. Here is a screenshot of text being printed in dark grey, which is almost completely unreadable.

image

Lots of software (e.g. Vim) will use dark grey as a foreground colour (e.g. for comments), which makes this hard to use.

@lighthaus-theme
Copy link
Owner

Hey

Sorry it took this long for me to reply, been very busy with a few things lately and this message just slipped by me.

However, this is not true. Here is a screenshot of text being printed in dark grey, which is almost completely unreadable.

Thanks for pointing it out. This is a big error on my part and I will correct it asap. Lemme test out a few things and then start pushing updates.

Will post updates on this thread as well.

@lighthaus-theme lighthaus-theme added the bug Something isn't working label Mar 19, 2021
@henrebotha
Copy link
Author

No stress! I know how open source works. Thanks for looking.

@lighthaus-theme
Copy link
Owner

Hey
I have changed the dark grey color.
New color is #8E8D8D

HAL 9000 2021-03-30 21-54-59(1)

I will be changing this in all of the repos, is gonna take a few days for all of them to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants