Delete algorithms and cipher checking #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wsargent the build fails. |
|
@mkurz Running into the same race condition... |
mkurz
reviewed
Jul 12, 2021
| @@ -37,7 +37,7 @@ final class KeyStoreConfig private[sslconfig] ( | |||
| val storeType: String = KeyStore.getDefaultType) { | |||
| assert(filePath.isDefined ^ data.isDefined, "Either key store path or data must be defined, but not both.") | |||
|
|
|||
| /** Disables `filePath` – only one of those can be used at any given time. */ | |||
| /** Disables `filePath` – only one of those can be used at any given time.com.typesafe.sslconfig.ssl.ConfigSSLContextBuilderSpec */ | |||
There was a problem hiding this comment.
@wsargent Seems like an unintended copy/paste?
|
@wsargent ping |
|
ack |
|
thanks Will! |
This was referenced Aug 3, 2021
Closed
This was referenced Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDK 1.8 and JDK 11 have much better security now and these can be removed.