Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sys.exit(-1) with sys.error(msg) #490

Merged
merged 1 commit into from
Apr 21, 2020

Conversation

htmldoug
Copy link
Contributor

@htmldoug htmldoug commented Apr 21, 2020

Problem

sbt mimaReportBinaryIssues is terminating the sbt process with System.exit(-1).

sbt:lib-weepickle-spices-parsers-play25-v1> mimaReportBinaryIssues
not a directory or jar file: /Users/doug.roper/code/lib-weepickle-spices/parsers-play25/target/scala-2.11/classes
$

Similar error condition to #55, but this PR is about preventing shutdown of the sbt's JVM when a mima problem occurs.

We've forked mima over this issue, but I'd like to get us back on mainline.

Testing

I've verified this manually using a snapshot:

sbt:lib-weepickle-spices> parsers-play25/mimaReportBinaryIssues
[error] stack trace is suppressed; run last parsers-play25 / mimaReportBinaryIssues for the full output
[error] (parsers-play25 / mimaReportBinaryIssues) not a directory or jar file: /Users/doug.roper/code/lib-weepickle-spices/parsers-play25/target/scala-2.11/classes
[error] Total time: 1 s, completed Apr 20, 2020 9:12:06 PM

I didn't add any new scripted tests since the change is pretty straightforward. Existing scripted tests all pass.

cc: @jrudolph @arkban

Copy link
Collaborator

@dwijnand dwijnand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, no problem. Thanks for the PR!

@dwijnand dwijnand merged commit f6692dc into lightbend-labs:master Apr 21, 2020
@SethTisue
Copy link
Collaborator

relic of MiMa's CLI days, I suppose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants