Report the loss of trait init methods #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
force-pushed
the
report-trait-init
branch
3 times, most recently
from
c6ad3a3 to
432d17f
Compare
In the encoding of traits the presence of a method with a body (a "concrete method") triggers the generation of a trait initialisation method, "$init$", which will be invoked by subclasses during construction. The effect this has is that dropping the last concrete method(s) from a trait _removes_ the trait init method, which is a binary incompatible change to client's subclasses. Fixes lightbend-labs#426
dwijnand
force-pushed
the
report-trait-init
branch
from
432d17f to
a1885e4
Compare
lrytz
approved these changes
Jan 14, 2020
|
Uh, I had no idea this would merge the PR 😄 |
|
Working as intended! 😄 |
|
Thanks much! Any chance of a new release soon? |
|
Hehe. Yep, just want to try to land #444 first. I might fast track that by exempting differences in Scala 2.11. I'll try this week or next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the encoding of traits the presence of a method with a body (a
"concrete method") triggers the generation of a trait initialisation
method, "$init$", which will be invoked by subclasses during
construction. The effect this has is that dropping the last concrete
method(s) from a trait removes the trait init method, which is a
binary incompatible change to client's subclasses.
Fixes #426