You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If/when MiMa understands Scala's notion of "package private" (good old #53) it would be good if the checks for concrete to abstract classes took into consideration that a concrete class with only a package private constructor can safely become abstract. This came up in the Vector rewrite of 2.13.2 (scala/scala#8534), specifically:
// Vector was final, now sealed, and has no accessible constructorProblemFilters.exclude[AbstractClassProblem]("scala.collection.immutable.Vector"),
...
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.Vector.this"),
ProblemFilters.exclude[DirectMissingMethodProblem]("scala.collection.immutable.Vector.apply"),
The missing (previously package private) constructor isn't a problem, as is the apply method only being abstract now instead of concrete.
However, this should also consider that abstract classes can extend concrete classes.
The text was updated successfully, but these errors were encountered:
If/when MiMa understands Scala's notion of "package private" (good old #53) it would be good if the checks for concrete to abstract classes took into consideration that a concrete class with only a package private constructor can safely become abstract. This came up in the Vector rewrite of 2.13.2 (scala/scala#8534), specifically:
The missing (previously package private) constructor isn't a problem, as is the
apply
method only being abstract now instead of concrete.However, this should also consider that abstract classes can extend concrete classes.
The text was updated successfully, but these errors were encountered: