Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otsu threshold implementation #72

Closed
anlava opened this issue Nov 7, 2022 · 0 comments · Fixed by #71
Closed

Otsu threshold implementation #72

anlava opened this issue Nov 7, 2022 · 0 comments · Fixed by #71
Assignees
Labels
bug Something isn't working

Comments

@anlava
Copy link
Contributor

anlava commented Nov 7, 2022

We now have a problem with this part of code:

delta_mean += mean - m;
let variance = delta_mean * delta_mean
                / (count - w).value_as::<T>().unwrap()
                / w.value_as::<T>().unwrap();

if variance < last_variance  {
                break;
            }

It seems that in some moment 'delta_mean' is too small which causes problems in further comparison of 'variance' and 'last_variance'.

@anlava anlava added the bug Something isn't working label Nov 7, 2022
@anlava anlava self-assigned this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant