Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of i128 types LoadFromMemory function #528

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Fix handling of i128 types LoadFromMemory function #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions lib/BC/Util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1774,9 +1774,11 @@ llvm::Value *LoadFromMemory(const IntrinsicTable &intrinsics,
case llvm::Type::PPC_FP128TyID: {
const auto size = dl.getTypeAllocSize(type);
auto res = ir.CreateAlloca(type);
auto i8_type = llvm::Type::getInt8Ty(context);

auto i8_array =
llvm::ArrayType::get(llvm::Type::getInt8Ty(context), size);
auto byte_array =
ir.CreateBitCast(res, llvm::PointerType::get(i8_type, 0));
ir.CreateBitCast(res, llvm::PointerType::get(i8_array, 0));
llvm::Value *gep_indices[2] = {
llvm::ConstantInt::get(index_type, 0, false), nullptr};

Expand All @@ -1787,7 +1789,7 @@ llvm::Value *LoadFromMemory(const IntrinsicTable &intrinsics,
addr, llvm::ConstantInt::get(addr->getType(), i, false));
auto byte = ir.CreateCall(intrinsics.read_memory_8, args_2);
gep_indices[1] = llvm::ConstantInt::get(index_type, i, false);
auto byte_ptr = ir.CreateInBoundsGEP(type, byte_array, gep_indices);
auto byte_ptr = ir.CreateInBoundsGEP(i8_array, byte_array, gep_indices);
ir.CreateStore(byte, byte_ptr);
}

Expand Down Expand Up @@ -1952,7 +1954,8 @@ llvm::Value *StoreToMemory(const IntrinsicTable &intrinsics,
auto res = ir.CreateAlloca(type);
ir.CreateStore(val_to_store, res);

auto i8_array = llvm::ArrayType::get(llvm::Type::getInt8Ty(context), size);
auto i8_array =
llvm::ArrayType::get(llvm::Type::getInt8Ty(context), size);
auto byte_array =
ir.CreateBitCast(res, llvm::PointerType::get(i8_array, 0));
llvm::Value *gep_indices[2] = {
Expand Down Expand Up @@ -2166,8 +2169,7 @@ llvm::Value *BuildPointerToOffset(llvm::IRBuilder<> &ir, llvm::Value *ptr,

// TODO(pag): Improve the API to take a `DataLayout`, perhaps.
} else {
LOG(FATAL)
<< "Unable to get the current module.";
LOG(FATAL) << "Unable to get the current module.";
}

auto &context = ptr->getContext();
Expand Down