Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New arch support #461

Merged
merged 138 commits into from
Feb 24, 2021
Merged

New arch support #461

merged 138 commits into from
Feb 24, 2021

Conversation

sschriner
Copy link
Contributor

No description provided.

pgoodman and others added 30 commits September 15, 2020 15:18
@pgoodman
This branch contains support for new architectures.
cdcf78f
@sschriner
Initial start to support for AArch 32
9876701
@sschriner
Progress
78961ef
@sschriner
Forgot the new files
f292370
@sschriner
Added all data Integer processing instructions without S + ADDS and s…
b83e040 
…tarted ANDS
@sschriner
Updated
aa954cd
@sschriner
Finished Integer Data Processing with three registers, added integer …
e3923a2 
…data processing with 2 regs + immediate, started MUL instructions
@sschriner
UMULL, UMULLS, UMLAL, UMLALS
67ba566
@sschriner
Corrected condition for addend or 0 immediate for UMULL/UMLAL + SMULL…
73f0d2a 
…/SMLAL instructions
@sschriner
Correct ops in Binary.cpp
8618494
@sschriner
UMAAL
4e88cbd
@sschriner
SMULL, SMULLS, SMLAL, SMLALS + corrected acc was missing shift left i…
4c9abfa 
…n concatination
@sschriner
Updated decoding instructions based on top level encodings
f71420d
@sschriner
Update returns around kDataProcessingRI and kDataProcessingI with com…
f5cb08b 
…ments to explain the correlation to the instruction rep
@sschriner
Added appropriate inst.category flags to Multiply and accumulate
cdc0587
@sschriner
Load/Store Word, Unsigned Byte (immediate, literal) && start of Logic…
8642940 
…al Arithmetic (three register, immediate shift)
@sschriner
Was missing UMAAL DEF_ISEL in Binary.cpp
e9e7b41
@sschriner
AddAddrRegOp
9d48aae
@sschriner
Logical Arithmetic (three register, immediate shift) without accounti…
5b82b03 
…ng for the possible PC jump
@sschriner
Made DecodeA32ExpandImm much much smaller
65af9f8
@sschriner
Replaced some imm ops with AddImmOp calls
25f4e50
@sschriner
Created AddShiftOp
14a7f06
@sschriner
Added interpreter for evaluating new PC value at decoding time to han…
26e6dbc 
…dle direct jumps and conditional jumps
@sschriner
Created EvalPCDest added PC evaluation to Logical Arithmetic Instruct…
2674607 
…ions
@sschriner
AddShiftOp -> AddShiftOp, AddShiftThenExtractOp, AddExtractThenShiftOp
f7b2cd9
@sschriner
Cleaned up some formatting, Renamed DecodeA32ExpandImm to ExpandTo32A…
f46cc4f 
…ddImmAddCarry and added a clarifying comment
@sschriner
Added comment to EvalPCDest for clarity
b3a98d3
@sschriner
Cleaned up some things, updated the decoding semantics and semantics …
e17750b 
…for the logical instructions
@sschriner
Shortened kLogArithEvaluators and fixed a bug
9d77145
@sschriner
Updates from testing instructions
6c819b2
@TheGreatRambler TheGreatRambler mentioned this pull request Jan 24, 2021
Open
pgoodman
pgoodman requested changes Feb 6, 2021
View reviewed changes
Copy link
Collaborator

@pgoodman pgoodman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only change requested is to run scripts/format-files (or whatever the code formatter is called)

:-)

Don't merge this at the end of a day; we'll need to quickly follow up with changes to Anvill and Circuitous.

@artemdinaburg
Copy link
Contributor

Is this ready for merging :) ?

pgoodman
pgoodman requested changes Feb 12, 2021
View reviewed changes
lib/BC/TraceLifter.cpp Outdated Show resolved Hide resolved
@pgoodman pgoodman merged commit 6322f79 into master Feb 24, 2021
@pgoodman pgoodman deleted the new_arch_support branch February 24, 2021 19:01
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgoodman pgoodman pgoodman requested changes

Assignees

@sschriner sschriner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sschriner @pgoodman @artemdinaburg @alessandrogario