Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] Investigate TM 0.35 vs 0.34 #200

Open
fmorency opened this issue Sep 13, 2022 · 8 comments
Open

[tracking] Investigate TM 0.35 vs 0.34 #200

fmorency opened this issue Sep 13, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@fmorency
Copy link
Contributor

fmorency commented Sep 13, 2022

TM 0.35.x was yanked.

Investigate the path of least resistance moving forward.

cf. liftedinit/roadmap#6

@fmorency fmorency added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 13, 2022
@fmorency fmorency self-assigned this Sep 13, 2022
@fmorency
Copy link
Contributor Author

CC @hansl

  • TM 0.37 will be based on TM 0.34
  • The only upgrade path supported for TM 0.37 is from TM 0.34
  • TM 0.37.0-alpha.X is already released

Recommendation: We should look into migrating from 0.35 to 0.34.

TODO: Investigate the required effort to migrate from 0.35 to 0.34.

References

@hansl
Copy link
Contributor

hansl commented Sep 19, 2022

Biggest question from me would be if we can run an hybrid 0.34 and 0.35 together in the same blockchain. If so, we might just need to write a many-abci bridge that speaks 0.34 protos and restart our own nodes one by one.

@fmorency
Copy link
Contributor Author

Update

  • I was able to run a hybrid network with 3 nodes on 0.35 and 1 node on 0.34
  • The 0.34 node was able to catch up with the 3 nodes on 0.35
  • The resiliency tests are passing on the hybrid network
  • Minor modifications are required
    • Some changes in many-abci to build against the tendermint* crates v0.25.0
    • Port the TM 0.35 configuration to TM 0.34
    • Fix p2p.max_packet_msg_payload_size to 1400 in TM 0.34 config file

@fmorency
Copy link
Contributor Author

Update 2

  • I was able to run a hybrid network with 2 nodes on 0.35 and 2 nodes on 0.34
  • The 0.34 node no.2 was able to catch up with the 2 nodes on 0.35 and the one node on 0.34
  • The resiliency tests are passing

Update 3

  • I was able to run a hybrid network with 1 node on 0.35 and 3 nodes on 0.34
  • The 0.34 node no.3 was able to catch up with the node on 0.35 and the two nodes on 0.34
  • The resiliency tests are passing

@hansl
Copy link
Contributor

hansl commented Oct 3, 2022

Update

  • Need to re-add block_by_hash to tendermint-rpc.
  • Instructions to create an hybrid testnet 34+35
  • many-abci need to be downgraded to 34.

@fmorency
Copy link
Contributor Author

fmorency commented Oct 5, 2022

tendermint-rpc PR: informalsystems/tendermint-rs#1206
hybrid testnet: liftedinit/many-framework#254

@fmorency
Copy link
Contributor Author

fmorency commented Oct 7, 2022

Update

  • tendermint-rpc PR has been merged

@hansl
Copy link
Contributor

hansl commented Oct 11, 2022

Next step: Need to build a testnet with 0.35 and upgrade some nodes to 0.34 and let it run a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants