-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump tokenfactory to 0.50.5 #109
Conversation
WalkthroughThe changes involve updates to the Changes
Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
🔇 Additional comments (4)go.mod (2)Line range hint Good catch on downgrading viper to address the GHSA-h395-qcrw-5vmq vulnerability.
The bump from v0.50.4-wasmvm2 to v0.50.5-wasmvm2 looks good. Let's verify there are no breaking changes. ✅ Verification successfulTokenfactory upgrade is safe to proceed The upgrade from v0.50.4-wasmvm2 to v0.50.5-wasmvm2 only adds a new query feature for denoms by admin without any breaking changes to existing interfaces. The changelog confirms this is a backwards-compatible feature addition. 🏁 Scripts executedThe following scripts were executed for the analysis: Script: #!/bin/bash
# Description: Check for breaking changes in tokenfactory upgrade
# Check the changelog or release notes
gh api repos/strangelove-ventures/tokenfactory/releases/tags/v0.50.5-wasmvm2 --jq .body
# Look for any major interface changes
rg -A 5 "type.*interface"
Length of output: 5581 interchaintest/go.mod (2)
The tokenfactory version bump to v0.50.5-wasmvm2 is consistent with the root go.mod file. Line range hint Good documentation explaining the ChainSafe/go-schnorrkel version requirements for Cosmos compatibility. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
=======================================
Coverage 77.96% 77.96%
=======================================
Files 33 33
Lines 2187 2187
=======================================
Hits 1705 1705
Misses 395 395
Partials 87 87 ☔ View full report in Codecov by Sentry. |
TF 0.50.5 allows querying denoms by denom owner.
Summary by CodeRabbit
cosmossdk.io/core
,github.com/cosmos/cosmos-sdk
, andgithub.aaakk.us.kg/spf13/viper
.interchaintest
module.