Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native types instead of SDK types #46

Open
fmorency opened this issue Nov 15, 2024 · 3 comments
Open

Use native types instead of SDK types #46

fmorency opened this issue Nov 15, 2024 · 3 comments
Assignees
Labels
blocked bug Something isn't working

Comments

@fmorency
Copy link
Contributor

We're querying the server REST endpoint which returns SDKType.

The SDKType generated by Telescope breaks the TS typing with numerical enums, e.g., ProposalStatus. The query will return the string field equivalent instead of the numerical value, even if the SDKType generated by Telescope expects the numerical value.

We should use native types instead.

Sadly, enabling toSDK and fromSDK in ManifestJS is not enough. Nested Any from the x/group module is broken.

This is a Telescope issue.

@fmorency fmorency added bug Something isn't working blocked labels Nov 15, 2024
@fmorency fmorency self-assigned this Nov 15, 2024
@fmorency
Copy link
Contributor Author

@chalabi2
Copy link
Collaborator

is this currently breaking anything in the ui?

@fmorency
Copy link
Contributor Author

No, this is something to be done in the future once Telescope is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants