Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background gallery to menu #15

Closed
fitztrev opened this issue Oct 27, 2023 · 1 comment · Fixed by #20
Closed

Add background gallery to menu #15

fitztrev opened this issue Oct 27, 2023 · 1 comment · Fixed by #20
Labels
bug Something isn't working

Comments

@fitztrev
Copy link
Member

On prod, when you select Picture background, there's a selection gallery, but not on local.

prod local
image image
@fitztrev fitztrev added the bug Something isn't working label Nov 1, 2023
@fitztrev
Copy link
Member Author

fitztrev commented Nov 8, 2023

env.net.assetBaseUrl value is http://localhost:8080 which is only accessible via the host machine. When the lila container requests that URL, it's not making it to the nginx container.

This is a hardcoded fix to the Dasher controller that gets it working and helps explain the issue:

   private lazy val galleryJson = env.memo.cacheApi.unit[Option[JsValue]]:
     _.refreshAfterWrite(1.minute)
       .buildAsyncFuture: _ =>
-        ws.url(s"${env.net.assetBaseUrl}/assets/lifat/background/gallery.json")
+        ws.url(s"http://nginx/assets/lifat/background/gallery.json")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant