Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getenv instead of hint for OpenGL texture_rectangle? #5422

Closed
icculus opened this issue Mar 20, 2022 · 2 comments
Closed

getenv instead of hint for OpenGL texture_rectangle? #5422

icculus opened this issue Mar 20, 2022 · 2 comments
Assignees
Milestone

Comments

@icculus
Copy link
Collaborator

icculus commented Mar 20, 2022

We're checking an environment variable here...

https://github.com/libsdl-org/SDL/blob/main/src/render/opengl/SDL_render_gl.c#L1850

...instead of an SDL hint (which will also check an environment variable, fwiw). @slouken, was this intentional, or can I change this to SDL_GetHintBoolean?

@icculus icculus added this to the 2.0.22 milestone Mar 20, 2022
@slouken
Copy link
Collaborator

slouken commented Mar 20, 2022

It's specifically using the environment variable to match what's happening in SDL_GL_ExtensionSupported()
I'm fine with changing it if we also change how that function works, but I wasn't sure we wanted to do that. I don't think setting an SDL hint should automatically change what extensions are used...

@slouken slouken closed this as completed Mar 20, 2022
@icculus
Copy link
Collaborator Author

icculus commented Mar 20, 2022

Okay, but let's reevaluate for SDL3.

#3519

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants