Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL_RenderTexture calls getting dropped #11490

Closed
kyle-sylvestre opened this issue Nov 17, 2024 · 2 comments
Closed

SDL_RenderTexture calls getting dropped #11490

kyle-sylvestre opened this issue Nov 17, 2024 · 2 comments
Assignees
Milestone

Comments

@kyle-sylvestre
Copy link
Contributor

Some of my texture calls near the bottom of the screen are getting dropped. After debugging I found that these lines are responsible. This is happening on devices where SDL_SetRenderScale is less than one. I believe it was due to GetRenderViewportSize being changed in ef758d0

SDL/src/render/SDL_render.c

Lines 3904 to 3910 in e027b85

GetRenderViewportSize(renderer, &real_dstrect);
if (dstrect) {
if (!SDL_HasRectIntersectionFloat(dstrect, &real_dstrect)) {
return true;
}
real_dstrect = *dstrect;
}

@slouken slouken added this to the 3.2.0 milestone Nov 17, 2024
@AntTheAlchemist
Copy link
Contributor

Same bug as #11318

@icculus icculus added the icculus-priority Things @icculus is looking at within a larger milestone. label Jan 8, 2025
@icculus
Copy link
Collaborator

icculus commented Jan 8, 2025

This is fixed by bf85320, thanks!

@icculus icculus closed this as completed Jan 8, 2025
@icculus icculus removed the icculus-priority Things @icculus is looking at within a larger milestone. label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants