Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Save state slot doesn't reset to 0 when starting content #12706

Closed
Brunnis opened this issue Jul 28, 2021 · 5 comments · Fixed by #17391
Closed

[UI] Save state slot doesn't reset to 0 when starting content #12706

Brunnis opened this issue Jul 28, 2021 · 5 comments · Fixed by #17391

Comments

@Brunnis
Copy link
Contributor

Brunnis commented Jul 28, 2021

Description

The save state slot that is selected before choosing "Close content" becomes the same save state slot that will be selected when launching new content. XMB and Ozone have been tested and behave the same.

Expected behavior

I would expect the save state slot to reset to the default (0) when launching content.

Actual behavior

Save state slot is remembered across content launches.

Steps to reproduce the bug

  1. Start any content and enter the Quick Menu.
  2. Set save state slot to, let's say, 2.
  3. Choose "Close content".
  4. Launch any content and enter the Quick Menu. The save state slot is still 2 (or whatever you set in step 2 above).

Version/Commit

  • RetroArch: 1.9.6

Environment information

  • OS: Windows 10
@Brunnis Brunnis changed the title [UI] Save state slot doesn't reset to 1 when starting content [UI] Save state slot doesn't reset to 0 when starting content Jul 29, 2021
@sonninnos
Copy link
Collaborator

Actually the selected slot state_slot is saved to global config for some reason, so there will be conflicts in resetting it if remembering is also desired.. I think it should go to zero on core unload or content close, but maybe someone knows better.

I hadn't noticed it at all since I don't have auto conf save enabled, so of course it is always 0 on launch.

@Brunnis
Copy link
Contributor Author

Brunnis commented Jul 30, 2021

@sonninnos Yeah, I noticed that it was saved to retroarch.cfg after I wrote this issue. Like you say, I assume there's probably some reason for this, although it's not obvious.

The auto conf save option, is that Settings -> Configuration -> Save Configuration on Quit you're referring to? I tried disabling it, but the save state slot is still remembered between content launches.

@sonninnos
Copy link
Collaborator

Sure, because it only prevents it from saving on quit, as the option name hints. That particular resource shouldn't get saved at all if you ask me.

@Brunnis
Copy link
Contributor Author

Brunnis commented Jul 30, 2021

Yeah, of course. From your previous message ("I hadn't noticed it at all since I don't have auto conf save enabled, so of course it is always 0 on launch."), it sounded like there was a setting that prevents automatic saving to the configuration file. The setting I mentioned was the closest I could find. Could you point me in the right direction, or did I misunderstand your previous message?

@sonninnos
Copy link
Collaborator

That is the setting I meant. It either saves everything or nothing, so it is not a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants