Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's Encrypt certificate not valid for Android 7 and older #7039

Open
3 tasks done
Pittvandewitt opened this issue Jan 29, 2025 · 5 comments
Open
3 tasks done

Let's Encrypt certificate not valid for Android 7 and older #7039

Pittvandewitt opened this issue Jan 29, 2025 · 5 comments
Labels
bug Something isn't working

Comments

@Pittvandewitt
Copy link
Contributor

Steps to reproduce

LibreTube is unable to use API calls on Android 7 or older because https://piped-instances.kavin.rocks/ and more domains use Let's Encrypt for their SSL certificates. The error thrown is javax.net.ssl.SSLHandshakeException: java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

For context: https://community.letsencrypt.org/t/support-for-android-7-and-older-from-oct-2024/216446

There are 2 solutions I can think of:

  1. Include the Let’s Encrypt root in LibreTube
  2. Bump the minSdk to 26 (Oreo)

Which one do you prefer? I'll happily make a PR for either solution.

Expected behavior

Content would load

Actual behavior

Content doesn't load

LibreTube version

Any

Android version

Android <= 7.1.1

Other details

Issue is occurring since Oct 2024

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Pittvandewitt Pittvandewitt added the bug Something isn't working label Jan 29, 2025
@Pittvandewitt
Copy link
Contributor Author

Here is how the certificate can be added: https://stackoverflow.com/a/78309587
Via xml on Android 7 or the clunky way on older Android versions.

The fact that nobody complained about this makes me wonder, why not use minSdk 26?

@FineFindus
Copy link
Contributor

FineFindus commented Jan 29, 2025

I think we should increase minSdk regardless, considering the app is broken on older Android version (cf. #7032, #6986)

@Pittvandewitt
Copy link
Contributor Author

the app is broken on older Android version

LibreTube includes a phonetically spelled english translation. The character set used is not available on older versions.
Either removing the translation or providing a better alternative (values-en) will fix those issues.

Applying fixes to better support these older Android versions is not that hard, but in the end it's not my call to make. The idea of not having to worry about (close to) obsolete devices is also appealing.

@Bnyro
Copy link
Member

Bnyro commented Jan 29, 2025

I think we should increase minSdk regardless, considering the app is broken on older Android version (cf. #7032, #6986)

I agree on bumping minSdk, there have been multiple issues with the app on old Android versions and I don't think it's worth keeping them supported.

@Bnyro Bnyro marked this as a duplicate of #7064 Feb 2, 2025
@Max20720
Copy link

Max20720 commented Feb 6, 2025

Is it really that bothersome? I for example have been counting on Libretube because the official Youtube app doesn't work on my cellphone anymore, it's been my lifesaver for a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants