Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip testing certain implementations #221

Closed
achingbrain opened this issue Jul 5, 2023 · 2 comments · Fixed by #225
Closed

Skip testing certain implementations #221

achingbrain opened this issue Jul 5, 2023 · 2 comments · Fixed by #225
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers

Comments

@achingbrain
Copy link
Member

Nim has a bug around identify which is breaking js-libp2p CI.

Since the multidim tests are now on the critical path for merging PRs this is something of a showstopper.

Is there a way to temporarily skip testing certain implementations?
@MarcoPolo
Copy link
Contributor

We can add a --name-ignore option that will filter out test cases with a matching substring (reverse of --name-filter)

@MarcoPolo MarcoPolo added exp/beginner Can be confidently tackled by newcomers effort/hours Estimated to take one or several hours labels Jul 5, 2023
@MarcoPolo
Copy link
Contributor

I'll add this unless you've started working on it.

@MarcoPolo MarcoPolo mentioned this issue Jul 6, 2023
Merged
@thomaseizinger thomaseizinger mentioned this issue Jul 6, 2023
Open
@MarcoPolo MarcoPolo mentioned this issue Jul 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/beginner Can be confidently tackled by newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

multidim-interop: Add name ignore option libp2p/test-plans
2 participants
@MarcoPolo @achingbrain