Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSockets: add spec #624

Merged
merged 3 commits into from
Oct 23, 2024
Merged

WebSockets: add spec #624

merged 3 commits into from
Oct 23, 2024

Conversation

achingbrain
Copy link
Member

Specifies the WebSockets transport with notes on certificates, multiplexing, etc.

It tries to document the current state of WebSocket transport with the exception of the http-path which I don't think is implemented anywhere.

A follow up PR to this PR will attempt to address the double-encryption problem as it's worthy of it's own discussion.

Please suggest an edit to the Interest Group if you want to be added.

Fixes #594

Specifies the WebSockets transport with notes on certificates,
multiplexing, etc.

Fixes #594
@achingbrain
Copy link
Member Author

One improvement we could make here is to use the protocols arg to specify the connection encrypter (e.g. "noise"), then use noise early data to select a stream multiplexer?

This would save a bunch of multistream-select round trips.

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads fine to me.. one comment

websockets/README.md Show resolved Hide resolved
@achingbrain achingbrain changed the title docs: add WebSockets spec WebSockets: add spec Sep 4, 2024
websockets/README.md Outdated Show resolved Hide resolved
@achingbrain
Copy link
Member Author

It's been a couple of months now so If there are no further comments here, I'm going to merge this at the end of the week.

websockets/README.md Outdated Show resolved Hide resolved
@achingbrain achingbrain merged commit 70441fa into master Oct 23, 2024
@achingbrain achingbrain deleted the docs/add-websockets-spec branch October 23, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Missing WebSockets (/ws, /wss) Transport Specification
3 participants