Introduce identify v2.0.0 based on signed peer records #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. This is unfortunate. Sending signed peer records has already been implemented in go-libp2p's identify but this was never added to the specs. The implementation is that we simply added a new field to the identify protobuf that includes the signed peer record. In terms of efficiency, this is less than optimal. But it lets us avoid an extra round-trip for version negotiation. |
|
Ah, I see the discussion. I'll continue there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed patch-by-patch.
I plan to amend 1d715ff as I work through feedback. Currently a draft PR because of discussion ongoing here.