-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kad): remove default IPFS protocol name #5122
Conversation
This pull request has merge conflicts. Could you please resolve them @guillaumemichel? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Just two comments :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Approvals have been dismissed because the PR was updated after the send-it
label was applied.
Description
Fixes: #5006.
Related: #5015.
Notes & open questions
Following suggestions from #5015 (comment)
Default
trait forkad::Config
andkad::ProtocolConfig
, but documenting it as deprecated.kad::Config::new(Vec<StreamProtocol>)
andkad::ProtocolConfig::new(Vec<StreamProtocol>)
to be used instead ofkad::Config::default()
andkad::ProtocolConfig::default()
.kad::Config::default()
andkad::ProtocolConfig::default()
, to prevent users from callingdefault()
.kad::Config::set_protocol_names
andkad::ProtocolConfig::set_protocol_names
, they should be replaced bykad::Config::new(Vec<StreamProtocol>)
andkad::ProtocolConfig::new(Vec<StreamProtocol>)
.Change checklist