Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chat-example): set idle_connection_timeout #4840

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix(chat-example): set idle_connection_timeout #4840

merged 2 commits into from
Nov 13, 2023

Conversation

thomaseizinger
Copy link
Contributor

Description

This one seems to have fallen through the cracks somehow. Without setting an idle connection timeout, the connection is immediately closed.

Related: #4837.

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@thomaseizinger thomaseizinger added send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer. labels Nov 13, 2023
@mergify mergify bot merged commit 9fed1a9 into master Nov 13, 2023
71 checks passed
@mergify mergify bot deleted the fix/chat-example branch November 13, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mergify mergify[bot] mergify[bot] approved these changes

Assignees
No one assigned
Labels
send-it trivial Marks PRs which are considered trivial and don't need approval from another maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thomaseizinger