feat: derive Clone for mdns::Event
#3606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm why the check failed? Is it a timeout? |
The WebRTC tests are flaky unfortunately. It is an upstream bug that is fixed in the latest version but we can't upgrade at the moment. See webrtc-rs/webrtc#413. I restarted the job, it will likely pass now. |
thomaseizinger
changed the title
Clone for mdns::Event
Patch version bump is good enough as this isn't breaking. |
Unreleased patch version 0.43.1 bumped. Added entry for PR 3606: Deriving 'Clone' for 'mdns::Event'
thomaseizinger
previously approved these changes
Mar 13, 2023
mergify
bot
dismissed
thomaseizinger’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
4 tasks
mxinden
reviewed
Mar 29, 2023
| @@ -1,3 +1,8 @@ | |||
| # 0.43.1 [unreleased] | |||
There was a problem hiding this comment.
This missed a version bump in protocols/mdns/Cargo.toml. I will make the bump with the upcoming release pull request.
mxinden
added a commit
to mxinden/rust-libp2p
that referenced
this pull request
Mar 29, 2023
Missed in libp2p#3606.
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2023
In previous PR #3606 we've made `mdns::Event` `Clone`, but cloning single-use iterators doesn't sound right. Also you have to create an iterator from the actual data returned before putting it into events. So in this PR the iterators are replaced by `Vec`, as it's the type the data originally come from. Related #3612. Pull-Request: #3621.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Derive trait
Cloneformdns::Event. This makes cloning its contents without destroying type information possible.Related #3593.
Notes & open questions
CHANGELOG to be filled. Should we open a new minor version for the change?
Change checklist