Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move ConnectionId from libp2p-core to libp2p-swarm #3200

Closed
thomaseizinger opened this issue Dec 7, 2022 · 2 comments
Closed

refactor: Move ConnectionId from libp2p-core to libp2p-swarm #3200

thomaseizinger opened this issue Dec 7, 2022 · 2 comments
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave

Comments

@thomaseizinger
Copy link
Contributor

Description

This type remaining in libp2p-core is a left-over from when Pool was still defined in libp2p-core. The overall move should be easy but it is technically a breaking chance and thus, we should wait with this until we ship some other breaking changes.

Motivation

  • Shrink the public API of libp2p-core
  • Define types as high up as possible to reduce unnecessary dependencies

Current Implementation

Are you planning to do it yourself in a pull request?

No.
@thomaseizinger thomaseizinger added priority:nicetohave help wanted getting-started Issues that can be tackled if you don't know the internals of libp2p very well labels Dec 7, 2022
@umgefahren umgefahren mentioned this issue Dec 9, 2022
Closed
2 tasks
@thomaseizinger
Copy link
Contributor Author

thomaseizinger commented Dec 14, 2022 •
edited
Loading

PendingPoint should be moved as well and made pub(crate) because it is only used in Pool. cc @umgefahren

@thomaseizinger
Copy link
Contributor Author

This is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
getting-started Issues that can be tackled if you don't know the internals of libp2p very well help wanted priority:nicetohave
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Move ConnectionId and PendingPoint to libp2p-swarm umgefahren/rust-libp2p
1 participant
@thomaseizinger