You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems that providers from GetProvidersResult could contain non-unique peers. I think that this behaviour could be error-prone for users of rust-libp2p (I've already stumbled with that:)) and providers should be unique.
The text was updated successfully, but these errors were encountered:
Sounds ok to me. Furthermore, if we want to introduce a configurable or hard-coded limit on how many providers to look for, terminating the query early if enough providers are found (as I think other libp2p-kad implementations offer), we would need to de-duplicate anyway.
Furthermore, if we want to introduce a configurable or hard-coded limit on how many providers to look for, terminating the query early if enough providers are found (as I think other libp2p-kad implementations offer), we would need to de-duplicate anyway.
It seems that
providers
fromGetProvidersResult
could contain non-unique peers. I think that this behaviour could be error-prone for users of rust-libp2p (I've already stumbled with that:)) and providers should be unique.The text was updated successfully, but these errors were encountered: