Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: wss as been replaced with tls/ws and autoNat is mandatory #2921

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

sfroment
Copy link
Contributor

@sfroment sfroment commented Jan 23, 2025

Signed-off-by: Sacha Froment [email protected]

Title

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@sfroment sfroment requested a review from a team as a code owner January 23, 2025 12:53
@achingbrain achingbrain changed the title fix: wss as been replaced with tls/ws and autoNat is mandatory docs: wss as been replaced with tls/ws and autoNat is mandatory Jan 23, 2025
@achingbrain
Copy link
Member

achingbrain commented Jan 23, 2025

Thanks for opening this. The READMEs are generated from the @packageDocumentation block in src/index.js so this changed also needs to be made here otherwise it'll get overwritten during the release.

@achingbrain achingbrain merged commit 827a38a into libp2p:main Jan 27, 2025
30 of 33 checks passed
@achingbrain achingbrain mentioned this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants