Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: release majors of modules that had patches during v1.0 #2286

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

achingbrain
Copy link
Member

Pre-v1.0 versions of libp2p are still depending on post-1.0 modules which means they have a mixed set of versions.

The change here is to cause those modules to have major releases.

BREAKING CHANGE: requires libp2p v1

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

Pre-v1.0 versions of libp2p are still depending on post-1.0 modules
which means they have a mixed set of versions.

The change here is to cause those modules to have major releases.

BREAKING CHANGE: requires libp2p v1
@achingbrain achingbrain requested a review from a team as a code owner December 1, 2023 16:16
@achingbrain achingbrain merged commit 738dd40 into main Dec 1, 2023
@achingbrain achingbrain deleted the fix/release-majors-of-mss-peer-store branch December 1, 2023 16:34
@achingbrain achingbrain mentioned this pull request Dec 1, 2023
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant