Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make mss check logger before use (#2261) #2274

Merged
merged 1 commit into from
Dec 1, 2023
Merged

fix: make mss check logger before use (#2261) #2274

merged 1 commit into from
Dec 1, 2023

Conversation

achingbrain
Copy link
Member

Check logger is present before use. Fixes a regression introduced during the 1.0 release where mss didn't go out as a major - reintroduces backwards compatibility.

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: make mss check logger before use (#2261)
b32a8b6 
Check logger is present before use. This should have gone out as a breaking change.
@achingbrain achingbrain requested a review from a team as a code owner November 30, 2023 21:16
@achingbrain achingbrain merged commit cf96369 into main Dec 1, 2023
@achingbrain achingbrain deleted the fix/make-mss-check-logger branch December 1, 2023 05:39
This was referenced Dec 1, 2023
Closed
Merged
This was referenced Jan 18, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain