Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libp2p): reduce dialer activity in browsers #1970

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 15, 2023

Use a different set of defaults for browsers vs node - from testing we never really see more than 20x connections so there's no point having the auto-dialler trying to reach 50x, also reduce the number of concurrent dials and how many peers we try to autodial at once.

This is to reduce overall CPU usage in order to make existing connections more stable.

Use a different set of defaults for browsers vs node - from testing
we never really see more than 20x connections so there's no point
having the auto-dialler trying to reach 50x, also reduce the number
of concurrent dials and how many peers we try to autodial at once.
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but is this actually reducing dialer activity in browsers, or just changing constants that still need consumed?

@achingbrain
Copy link
Member Author

but is this actually reducing dialer activity in browsers, or just changing constants that still need consumed?

Yes, this will reduce dialer activity in browsers.

@achingbrain achingbrain merged commit d30f09f into master Aug 15, 2023
@achingbrain achingbrain deleted the fix/reduce-dialer-activity-in-browsers branch August 15, 2023 16:17
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants