From dcf2e8e851771ea4dad025c3808d25533a06e651 Mon Sep 17 00:00:00 2001
From: Alex Potsides <alex@achingbrain.net>
Date: Thu, 2 Mar 2023 12:07:45 +0000
Subject: [PATCH] fix: remove it-pipe (#69)

Every iteration of every pipeline function in `it-pipe` crosses an
async boundary so it can harm performance if your pipleline would
otherwise be synchronous.

Fixes #44
---
 package.json        |  1 -
 src/address-book.ts | 31 ++++++++++++++++---------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/package.json b/package.json
index e14a0779ab..0f31297ebf 100644
--- a/package.json
+++ b/package.json
@@ -158,7 +158,6 @@
     "it-filter": "^2.0.0",
     "it-foreach": "^1.0.0",
     "it-map": "^2.0.0",
-    "it-pipe": "^2.0.3",
     "mortice": "^3.0.0",
     "multiformats": "^11.0.0",
     "protons-runtime": "^5.0.0",
diff --git a/src/address-book.ts b/src/address-book.ts
index 9b7580a6dc..fd3d10ffe3 100644
--- a/src/address-book.ts
+++ b/src/address-book.ts
@@ -3,11 +3,6 @@ import { CodeError } from '@libp2p/interfaces/errors'
 import { isMultiaddr } from '@multiformats/multiaddr'
 import { codes } from './errors.js'
 import { PeerRecord, RecordEnvelope } from '@libp2p/peer-record'
-import { pipe } from 'it-pipe'
-import all from 'it-all'
-import filter from 'it-filter'
-import map from 'it-map'
-import each from 'it-foreach'
 import { peerIdFromPeerId } from '@libp2p/peer-id'
 import { CustomEvent } from '@libp2p/interfaces/events'
 import type { Address, AddressFilter, Peer, PeerMultiaddrsChangeData, PeerStore } from '@libp2p/interface-peer-store'
@@ -346,21 +341,27 @@ export class PeerStoreAddressBook {
 }
 
 async function filterMultiaddrs (peerId: PeerId, multiaddrs: Multiaddr[], addressFilter: AddressFilter, isCertified: boolean = false): Promise<Address[]> {
-  return await pipe(
-    multiaddrs,
-    (source) => each(source, (multiaddr) => {
+  const output: Address[] = []
+
+  await Promise.all(
+    multiaddrs.map(async multiaddr => {
       if (!isMultiaddr(multiaddr)) {
         log.error('multiaddr must be an instance of Multiaddr')
         throw new CodeError('multiaddr must be an instance of Multiaddr', codes.ERR_INVALID_PARAMETERS)
       }
-    }),
-    (source) => filter(source, async (multiaddr) => await addressFilter(peerId, multiaddr)),
-    (source) => map(source, (multiaddr) => {
-      return {
+
+      const include = await addressFilter(peerId, multiaddr)
+
+      if (!include) {
+        return
+      }
+
+      output.push({
         multiaddr,
         isCertified
-      }
-    }),
-    async (source) => await all(source)
+      })
+    })
   )
+
+  return output
 }