-
Notifications
You must be signed in to change notification settings - Fork 15
Conversation
Thanks! Could you also update the readme? Need to kill those addresses before people start using them :P I'm also thinking it's okay to completely remove the no-/tcp support here since there's no backwards-compat concerns as with the webrtc transport, but that's @diasdavid's call I guess :) |
I would be fine with both but you do bring a good point and since we have the chance, let's do as @lgierth suggests. |
Tests are failing because of this issue on aegis: ipfs/aegir#177 |
Can we have that test skipped for now so that CI is green but with a comment above pointing to the issue reporting the problem? Thank you! |
…failing because env vars are not being propagated into the browser
@pgte now it fails because of linting https://travis-ci.org/libp2p/js-libp2p-websocket-star/jobs/309424155#L2297 |
Fixes #37