Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Fix/add tcp port support #38

Merged
merged 7 commits into from
Nov 30, 2017
Merged

Fix/add tcp port support #38

merged 7 commits into from
Nov 30, 2017

Conversation

pgte
Copy link
Contributor

@pgte pgte commented Nov 29, 2017

Fixes #37

@ghost ghost assigned pgte Nov 29, 2017
@ghost ghost added the in progress label Nov 29, 2017
@ghost
Copy link

ghost commented Nov 29, 2017

Thanks! Could you also update the readme? Need to kill those addresses before people start using them :P

I'm also thinking it's okay to completely remove the no-/tcp support here since there's no backwards-compat concerns as with the webrtc transport, but that's @diasdavid's call I guess :)

@daviddias
Copy link
Member

I'm also thinking it's okay to completely remove the no-/tcp support here since there's no backwards-compat concerns as with the webrtc transport, but that's @diasdavid's call I guess :)

I would be fine with both but you do bring a good point and since we have the chance, let's do as @lgierth suggests.

@pgte
Copy link
Contributor Author

pgte commented Nov 30, 2017

@lgierth docs: done by d2037bc.

deprecate no-tcp: I think this line enforces that.

@pgte
Copy link
Contributor Author

pgte commented Nov 30, 2017

Tests are failing because of this issue on aegis: ipfs/aegir#177

@daviddias
Copy link
Member

Can we have that test skipped for now so that CI is green but with a comment above pointing to the issue reporting the problem? Thank you!

…failing because env vars are not being propagated into the browser
@daviddias
Copy link
Member

@daviddias daviddias merged commit 92af753 into master Nov 30, 2017
@daviddias daviddias deleted the fix/add-tcp-port-support branch November 30, 2017 12:56
@ghost ghost removed the in progress label Nov 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants