Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Commit

Permalink
fix: Ci
Browse files Browse the repository at this point in the history
  • Loading branch information
mkg20001 committed Nov 23, 2017
1 parent 9120e92 commit 2402df2
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function validate (def, data) {
if (!Array.isArray(data)) throw new Error('Data is not an array')
def.forEach((type, index) => {
if (!types[type]) {
console.error('Type %s does not exist', type)
console.error('Type %s does not exist', type) // eslint-disable-line no-console
throw new Error('Type ' + type + ' does not exist')
}
if (!types[type](data[index])) throw new Error('Data at index ' + index + ' is invalid for type ' + type)
Expand Down
4 changes: 2 additions & 2 deletions test/dial.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,15 +38,15 @@ describe('dial', () => {

if (process.env.REMOTE_DNS) {
// test with deployed signalling server using DNS
console.log('Using DNS:', maDNS, maDNS6)
console.log('Using DNS:', maDNS, maDNS6) // eslint-disable-line no-console
ma1 = maGen(maDNS, peerId1)
// ma1v6 = maGen(maDNS6, peerId1)

ma2 = maGen(maDNS, peerId2)
ma2v6 = maGen(maDNS6, peerId2)
} else if (process.env.REMOTE_IP) {
// test with deployed signalling server using IP
console.log('Using IP:', maRemoteIP4, maRemoteIP6)
console.log('Using IP:', maRemoteIP4, maRemoteIP6) // eslint-disable-line no-console
ma1 = maGen(maRemoteIP4, peerId1)
// ma1v6 = maGen(maRemoteIP6, peerId1)

Expand Down
4 changes: 3 additions & 1 deletion test/listen.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ const multiaddr = require('multiaddr')

const WebSocketStar = require('../src')

const skiptravis = process.env.TRAVIS ? it.skip : it

describe('listen', () => {
let ws

Expand Down Expand Up @@ -51,7 +53,7 @@ describe('listen', () => {
// TODO ? Should this apply ?
})

it('listen on IPv6 addr', (done) => {
skiptravis('listen on IPv6 addr', (done) => {

This comment has been minimized.

Copy link
@victorb

victorb Nov 27, 2017

Member

Can we add a comment about why this is skipped on Travis and not the others?

This comment has been minimized.

Copy link
@mkg20001

mkg20001 Nov 27, 2017

Author Member

Travis has IPv6 issues. It works on other ci providers.
Btw in the browser this test isn't really skipped because ipfs/aegir#177

This comment has been minimized.

Copy link
@victorb

victorb Nov 27, 2017

Member

I see. Still, point of my comment here on Github was to add a comment in the code, to give context about why it's skipped.

This comment has been minimized.

Copy link
@mkg20001

mkg20001 Nov 27, 2017

Author Member

Added 0052d19

const listener = ws.createListener((conn) => {})

listener.listen(mav6, (err) => {
Expand Down

0 comments on commit 2402df2

Please sign in to comment.