This repository has been archived by the owner on Jun 11, 2020. It is now read-only.
Remove warning for too many listeners on socket.io sockets #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's fairly normal to have more than 10 listeners on a socket for the rendezvous server.
jacobheun
approved these changes
Nov 27, 2018
There was a problem hiding this comment.
For additional context; I spent some time going through this, the warning is coming from the disconnect listener on socket.io-pull-stream. Anytime a stream is created for a given socket that listener is added, so that when the socket ends it cleans up any open streams.
I think there is a possible even listener leak in socket.io-pull-stream, I'll create an issue there. It doesn't impact this change though.
The CI error is commitlint, I'll fix the commit message on squash and merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's fairly normal to have more than 10 listeners on a socket for the
rendezvous server.
This small change makes the test cases for peer-star-app much less chatty.