-
Notifications
You must be signed in to change notification settings - Fork 60
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested a couple of small changes. Is there a reason for adding async
to methods that already return Promises? If I understand correctly this will just add an extra layer of Promises without any functional change in the code?
@dirkmc committed the comment changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @kumavis thanks!
Just two minor requests
Also, could you increase the bundlesize max size in |
05e1500
to
c5e9a9a
Compare
@vasco-santos @jacobheun ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
providers.js hasn't been touched in a while, so this is mostly directly taken from #82
Added some async/callback wrappers here and there and used
pull-stream-to-async-iterator
arounddatastore.query
as #82 originally relied on the new datastore interfaceFixes #124