fix!: update pubsub subscribe method to return subscription #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribing to pubsub topics is a two step process - first we subscribe then we recieve messages. We may subscribe and not receive messages, so change the return type to reflect that. It now returns a promise, after which is resolved the node is subscribed, and the response has a `messages` method that can be used to iterate over any received messages, and a `cancel` method that will cancel the subscription.
github-actions bot
pushed a commit
that referenced
this pull request
Feb 24, 2023
## [@libp2p/daemon-client-v5.0.0](https://github.com/libp2p/js-libp2p-daemon/compare/@libp2p/daemon-client-v4.1.0...@libp2p/daemon-client-v5.0.0) (2023-02-24) ### ⚠ BREAKING CHANGES * update pubsub subscribe method to return subscription (#186) ### Bug Fixes * update pubsub subscribe method to return subscription ([#186](#186)) ([88e4bf5](88e4bf5))
|
🎉 This PR is included in version @libp2p/daemon-client-v5.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 1, 2024
## [1.0.0](v0.10.2...v1.0.0) (2024-08-01) ### ⚠ BREAKING CHANGES * updates js-libp2p to v1 * stream close methods are now asyc, requires [email protected] or later * the type of the source/sink properties have changed * update pubsub subscribe method to return subscription (#186) * Update multiformats and related dependencies (#170) * the stream type returned by `client.openStream` has changed * uses new single-issue libp2p interface modules * This module is now ESM only ### Features * add get subscribers for pubsub topics ([#184](#184)) ([c8be43e](c8be43e)) * close streams gracefully ([#213](#213)) ([92eebfa](92eebfa)) * convert to typescript ([#78](#78)) ([f18b2a4](f18b2a4)) * update to latest libp2p interfaces ([#102](#102)) ([f5e9121](f5e9121)) ### Bug Fixes * add additional logging ([94d21cb](94d21cb)) * add logger field ([#234](#234)) ([6f4728c](6f4728c)) * allow opening remote streams ([#126](#126)) ([361cc57](361cc57)) * encode enums correctly ([#86](#86)) ([6ce4633](6ce4633)) * fix proto file and generated code ([#94](#94)) ([5c22052](5c22052)), closes [#66](#66) * handle empty responses ([#145](#145)) ([0dfb823](0dfb823)) * read stream data using lp stream ([#242](#242)) ([ee746f6](ee746f6)) * remove protobufjs and replace with protons ([#81](#81)) ([78dd02a](78dd02a)) * restore proto2 compatibility ([#146](#146)) ([9fe8e04](9fe8e04)) * update all deps ([#124](#124)) ([5e46e1e](5e46e1e)) * update deps ([#90](#90)) ([b50eba3](b50eba3)) * update generated file ([#82](#82)) ([fc66301](fc66301)) * update interfaces and deps ([#84](#84)) ([25173d5](25173d5)) * update pubsub subscribe method to return subscription ([#186](#186)) ([88e4bf5](88e4bf5)) * use "limited" instead of "transient" ([#272](#272)) ([d43c177](d43c177)) * use interface-libp2p to ensure the correct services are set ([#203](#203)) ([8602a70](8602a70)) ### Trivial Changes * add docs ([ffc0e14](ffc0e14)) * add or force update .github/workflows/js-test-and-release.yml ([#216](#216)) ([5d68727](5d68727)) * delete templates [skip ci] ([#215](#215)) ([1fdc6ff](1fdc6ff)) * **deps:** bump lerna from 4.0.0 to 5.1.2 ([#97](#97)) ([1ae7428](1ae7428)) * **release:** 1.0.0 [skip ci] ([52438f1](52438f1)), closes [#78](#78) * **release:** 1.0.0 [skip ci] ([7bf2269](7bf2269)), closes [#78](#78) * **release:** 1.0.0 [skip ci] ([b721c9c](b721c9c)), closes [#78](#78) * **release:** 1.0.0 [skip ci] ([4e7a293](4e7a293)), closes [#78](#78) * **release:** 1.0.1 [skip ci] ([1747bb0](1747bb0)), closes [#80](#80) * **release:** 1.0.1 [skip ci] ([e11bee3](e11bee3)), closes [#81](#81) [#80](#80) * **release:** 1.0.1 [skip ci] ([79a6374](79a6374)), closes [#81](#81) [#80](#80) * **release:** 1.0.1 [skip ci] ([8c6e03a](8c6e03a)), closes [#80](#80) * **release:** 1.0.2 [skip ci] ([e62646f](e62646f)), closes [#84](#84) * **release:** 1.0.2 [skip ci] ([4974d58](4974d58)), closes [#84](#84) * **release:** 1.0.2 [skip ci] ([a0608ab](a0608ab)), closes [#84](#84) * **release:** 1.0.2 [skip ci] ([7e10176](7e10176)), closes [#81](#81) * **release:** 1.0.3 [skip ci] ([01e2a7b](01e2a7b)), closes [#90](#90) * **release:** 1.0.3 [skip ci] ([805ec74](805ec74)), closes [#86](#86) * **release:** 1.0.3 [skip ci] ([db1b1bd](db1b1bd)), closes [#86](#86) * **release:** 1.0.3 [skip ci] ([11365b9](11365b9)), closes [#82](#82) * **release:** 1.0.4 [skip ci] ([0e3a398](0e3a398)), closes [#83](#83) * **release:** 1.0.4 [skip ci] ([3dfbf95](3dfbf95)), closes [#90](#90) * **release:** 1.0.4 [skip ci] ([ec5305a](ec5305a)), closes [#90](#90) * **release:** 1.0.4 [skip ci] ([b5a03c4](b5a03c4)), closes [#84](#84) * **release:** 1.0.5 [skip ci] ([d465779](d465779)), closes [#83](#83) * **release:** 1.0.5 [skip ci] ([0daaf34](0daaf34)), closes [#83](#83) * **release:** 1.0.5 [skip ci] ([6696938](6696938)), closes [#86](#86) * **release:** 1.0.6 [skip ci] ([e66d19f](e66d19f)), closes [#83](#83) * **release:** 2.0.0 [skip ci] ([92bb2fe](92bb2fe)), closes [#102](#102) * **release:** 2.0.0 [skip ci] ([b5c5eab](b5c5eab)), closes [#102](#102) * **release:** 2.0.0 [skip ci] ([ad2c0c3](ad2c0c3)), closes [#102](#102) * **release:** 2.0.0 [skip ci] ([3f84767](3f84767)), closes [#102](#102) * **release:** 2.0.1 [skip ci] ([4fc0426](4fc0426)), closes [#111](#111) [#115](#115) * **release:** 2.0.1 [skip ci] ([0497889](0497889)), closes [#103](#103) * **release:** 2.0.1 [skip ci] ([1ae14ed](1ae14ed)), closes [#103](#103) * **release:** 2.0.1 [skip ci] ([d81c56b](d81c56b)), closes [#103](#103) * **release:** 2.0.2 [skip ci] ([3f9028d](3f9028d)), closes [#111](#111) * **release:** 2.0.2 [skip ci] ([56738b8](56738b8)), closes [#124](#124) * **release:** 2.0.2 [skip ci] ([cc3c27a](cc3c27a)), closes [#105](#105) * **release:** 2.0.2 [skip ci] ([d6ce9be](d6ce9be)), closes [#105](#105) * **release:** 2.0.3 [skip ci] ([259b089](259b089)), closes [#128](#128) * **release:** 2.0.3 [skip ci] ([601d75f](601d75f)), closes [#111](#111) [#115](#115) * **release:** 2.0.3 [skip ci] ([ab83d91](ab83d91)), closes [#111](#111) [#115](#115) * **release:** 2.0.4 [skip ci] ([e81bd17](e81bd17)), closes [#143](#143) * **release:** 2.0.4 [skip ci] ([8380f68](8380f68)), closes [#124](#124) * **release:** 2.0.4 [skip ci] ([774489b](774489b)), closes [#124](#124) * **release:** 2.0.5 [skip ci] ([d5eb5df](d5eb5df)) * **release:** 2.0.6 [skip ci] ([f5caad6](f5caad6)), closes [#171](#171) [#166](#166) * **release:** 2.0.7 [skip ci] ([820fc13](820fc13)), closes [#183](#183) * **release:** 2.0.8 [skip ci] ([9318c3d](9318c3d)), closes [#189](#189) * **release:** 2.0.9 [skip ci] ([0d40140](0d40140)) * **release:** 3.0.0 [skip ci] ([abf0f03](abf0f03)), closes [#213](#213) [#202](#202) * **release:** 3.0.0 [skip ci] ([961dc48](961dc48)), closes [#126](#126) * **release:** 3.0.0 [skip ci] ([95c9ff4](95c9ff4)), closes [#126](#126) * **release:** 3.0.0 [skip ci] ([0de52f6](0de52f6)), closes [#126](#126) * **release:** 3.0.1 [skip ci] ([f9e1bdc](f9e1bdc)), closes [#232](#232) [#231](#231) * **release:** 3.0.1 [skip ci] ([ff9d108](ff9d108)), closes [#128](#128) * **release:** 3.0.1 [skip ci] ([ba74e73](ba74e73)), closes [#128](#128) * **release:** 3.0.1 [skip ci] ([7872dd9](7872dd9)), closes [#94](#94) [#66](#66) * **release:** 3.0.2 [skip ci] ([f2ac1a0](f2ac1a0)), closes [#133](#133) [#130](#130) * **release:** 3.0.2 [skip ci] ([81747bb](81747bb)), closes [#132](#132) * **release:** 3.0.2 [skip ci] ([bf01140](bf01140)), closes [#132](#132) * **release:** 3.0.3 [skip ci] ([9cca0f6](9cca0f6)), closes [#143](#143) * **release:** 3.0.3 [skip ci] ([0621959](0621959)), closes [#143](#143) * **release:** 3.0.3 [skip ci] ([6f8870f](6f8870f)), closes [#143](#143) * **release:** 3.0.4 [skip ci] ([851d0f6](851d0f6)), closes [#145](#145) [#146](#146) * **release:** 3.0.4 [skip ci] ([f5adaaf](f5adaaf)), closes [#144](#144) * **release:** 3.0.4 [skip ci] ([5eeca2e](5eeca2e)), closes [#144](#144) * **release:** 3.0.5 [skip ci] ([92c523f](92c523f)), closes [#171](#171) [#179](#179) * **release:** 3.0.5 [skip ci] ([6a84503](6a84503)), closes [#147](#147) * **release:** 3.0.5 [skip ci] ([f1cb7d6](f1cb7d6)), closes [#145](#145) * **release:** 3.0.6 [skip ci] ([f63a3ec](f63a3ec)), closes [#183](#183) * **release:** 3.0.6 [skip ci] ([c8be47c](c8be47c)), closes [#148](#148) * **release:** 4.0.0 [skip ci] ([7094dc2](7094dc2)), closes [#235](#235) * **release:** 4.0.0 [skip ci] ([853b96e](853b96e)), closes [#196](#196) * **release:** 4.0.0 [skip ci] ([6fdc9d5](6fdc9d5)), closes [#170](#170) [#170](#170) * **release:** 4.0.0 [skip ci] ([0125247](0125247)), closes [#170](#170) [#170](#170) * **release:** 4.0.1 [skip ci] ([ea4d6f9](ea4d6f9)), closes [#262](#262) * **release:** 4.0.1 [skip ci] ([ed59a4d](ed59a4d)), closes [#201](#201) * **release:** 4.0.1 [skip ci] ([f11b093](f11b093)), closes [#165](#165) * **release:** 4.0.1 [skip ci] ([4065f5c](4065f5c)), closes [#165](#165) * **release:** 4.0.2 [skip ci] ([2ebe6d3](2ebe6d3)), closes [#267](#267) * **release:** 4.0.2 [skip ci] ([82f828e](82f828e)), closes [#171](#171) [#1269](https://github.com/libp2p/js-libp2p-daemon/issues/1269) [#166](#166) * **release:** 4.0.2 [skip ci] ([1eaaa4e](1eaaa4e)), closes [#171](#171) [#166](#166) * **release:** 4.0.3 [skip ci] ([7aa158d](7aa158d)), closes [#183](#183) * **release:** 4.0.3 [skip ci] ([b7444f7](b7444f7)), closes [#183](#183) * **release:** 4.1.0 [skip ci] ([d66ad92](d66ad92)), closes [#184](#184) * **release:** 4.1.0 [skip ci] ([9bbbfc1](9bbbfc1)), closes [#184](#184) * **release:** 4.1.1 [skip ci] ([371c1b4](371c1b4)), closes [#189](#189) * **release:** 4.1.2 [skip ci] ([a1040ae](a1040ae)), closes [#190](#190) * **release:** 4.1.3 [skip ci] ([f70961b](f70961b)), closes [#193](#193) * **release:** 4.1.4 [skip ci] ([bcaba11](bcaba11)), closes [#195](#195) * **release:** 5.0.0 [skip ci] ([3132144](3132144)), closes [#213](#213) [#202](#202) * **release:** 5.0.0 [skip ci] ([b24c2d0](b24c2d0)), closes [#196](#196) * **release:** 5.0.0 [skip ci] ([fedcbdf](fedcbdf)), closes [#186](#186) [#186](#186) * **release:** 5.0.1 [skip ci] ([f6c96a9](f6c96a9)), closes [#232](#232) * **release:** 5.0.1 [skip ci] ([191e7e1](191e7e1)), closes [#201](#201) * **release:** 5.0.1 [skip ci] ([1031585](1031585)), closes [#189](#189) * **release:** 5.0.2 [skip ci] ([bba7ff7](bba7ff7)), closes [#203](#203) * **release:** 5.0.2 [skip ci] ([92b333b](92b333b)), closes [#193](#193) * **release:** 5.0.3 [skip ci] ([b77587d](b77587d)), closes [#195](#195) * **release:** 6.0.0 [skip ci] ([fc9401e](fc9401e)), closes [#235](#235) * **release:** 6.0.0 [skip ci] ([0fb53b6](0fb53b6)), closes [#213](#213) [#202](#202) * **release:** 6.0.0 [skip ci] ([bb95f11](bb95f11)), closes [#196](#196) * **release:** 6.0.1 [skip ci] ([5ba7136](5ba7136)), closes [#242](#242) * **release:** 6.0.1 [skip ci] ([677ccc8](677ccc8)), closes [#214](#214) * **release:** 6.0.1 [skip ci] ([9eb8cdb](9eb8cdb)), closes [#199](#199) * **release:** 6.0.2 [skip ci] ([4ec90f3](4ec90f3)), closes [#262](#262) * **release:** 6.0.2 [skip ci] ([0e0492a](0e0492a)), closes [#232](#232) [#233](#233) * **release:** 6.0.2 [skip ci] ([26e99b2](26e99b2)), closes [#201](#201) * **release:** 6.0.3 [skip ci] ([ef742b1](ef742b1)), closes [#234](#234) * **release:** 6.0.3 [skip ci] ([802c9ec](802c9ec)), closes [#203](#203) * **release:** 7.0.0 [skip ci] ([c1a38e1](c1a38e1)), closes [#235](#235) * **release:** 7.0.0 [skip ci] ([2d64c3d](2d64c3d)), closes [#213](#213) [#202](#202) * **release:** 7.0.1 [skip ci] ([7de5766](7de5766)), closes [#244](#244) * **release:** 7.0.1 [skip ci] ([b535567](b535567)), closes [#214](#214) * **release:** 7.0.2 [skip ci] ([b0e7803](b0e7803)), closes [#253](#253) [#248](#248) * **release:** 7.0.2 [skip ci] ([906b0d1](906b0d1)), closes [#232](#232) [#231](#231) [#233](#233) * **release:** 7.0.3 [skip ci] ([8b36b29](8b36b29)), closes [#262](#262) * **release:** 7.0.3 [skip ci] ([3f67560](3f67560)), closes [#234](#234) * **release:** 7.0.4 [skip ci] ([648a95d](648a95d)), closes [#261](#261) [#263](#263) * **release:** 7.0.5 [skip ci] ([00c7a65](00c7a65)), closes [#265](#265) * **release:** 7.0.6 [skip ci] ([5e27a28](5e27a28)), closes [#272](#272) * **release:** 8.0.0 [skip ci] ([ed64183](ed64183)), closes [#235](#235) * **release:** 8.0.1 [skip ci] ([36203a9](36203a9)), closes [#244](#244) * **release:** 8.0.3 [skip ci] ([6cff7f1](6cff7f1)), closes [#262](#262) * **release:** 8.0.4 [skip ci] ([7994da5](7994da5)), closes [#261](#261) [#263](#263) * **release:** 8.0.5 [skip ci] ([1cb0a63](1cb0a63)), closes [#265](#265) * **release:** 8.0.6 [skip ci] ([842f339](842f339)), closes [#267](#267) * remove lerna ([#171](#171)) ([367f912](367f912)) * replace err-code with CodeError ([#172](#172)) ([c330fd5](c330fd5)), closes [#1269](https://github.com/libp2p/js-libp2p-daemon/issues/1269) * Update .github/pull_request_template.md [skip ci] ([ffaba1d](ffaba1d)) * Update .github/pull_request_template.md [skip ci] ([85da5bc](85da5bc)) * Update .github/pull_request_template.md [skip ci] ([408f934](408f934)) * update .github/workflows/js-test-and-release.yml ([#243](#243)) ([fc4bf48](fc4bf48)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([149958e](149958e)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([48c6d38](48c6d38)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([3726bb4](3726bb4)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([bfe013b](bfe013b)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([5120486](5120486)) * Update .github/workflows/semantic-pull-request.yml [skip ci] ([6613915](6613915)) * Update .github/workflows/stale.yml [skip ci] ([2a33976](2a33976)) * Update .github/workflows/stale.yml [skip ci] ([72aab1b](72aab1b)) * Update .github/workflows/stale.yml [skip ci] ([7414a71](7414a71)) * Update .github/workflows/stale.yml [skip ci] ([cd893ef](cd893ef)) * Update .github/workflows/stale.yml [skip ci] ([8c715d2](8c715d2)) * update aegir to latest version ([#80](#80)) ([3a98959](3a98959)) * update CI config files ([#125](#125)) ([0a98092](0a98092)) * Update CODEOWNERS [skip ci] ([191b38e](191b38e)) * update deps ([#103](#103)) ([2bfaa37](2bfaa37)) * update deps ([#105](#105)) ([0bdab0e](0bdab0e)) * update docs ([#91](#91)) ([5b072ff](5b072ff)), closes [#83](#83) * update project config ([#111](#111)) ([345e663](345e663)) * update sibling dependencies ([c3a9e55](c3a9e55)) * update sibling dependencies ([3e711d1](3e711d1)) * update sibling dependencies ([865cb8a](865cb8a)) ### Documentation * readme update ([f569ffc](f569ffc)) * update readme ([5f929a0](5f929a0)) ### Dependencies * bump @chainsafe/libp2p-gossipsub from 10.1.1 to 11.0.0 ([#244](#244)) ([6cc8c3c](6cc8c3c)) * bump @chainsafe/libp2p-gossipsub from 11.2.1 to 13.0.0 ([#265](#265)) ([bcd5041](bcd5041)) * bump @chainsafe/libp2p-gossipsub from 9.1.0 to 10.0.0 ([#214](#214)) ([0308811](0308811)) * bump @libp2p/interface-connection from 3.1.1 to 4.0.0 ([#195](#195)) ([798ecc5](798ecc5)) * bump @libp2p/interface-peer-store from 1.2.9 to 2.0.0 ([#201](#201)) ([9b146a8](9b146a8)) * bump @libp2p/interface-transport from 1.0.4 to 2.0.0 ([#132](#132)) ([1a7b2cc](1a7b2cc)) * bump @libp2p/kad-dht from 11.0.8 to 12.0.5 ([#261](#261)) ([1cbaa23](1cbaa23)) * bump @libp2p/tcp from 3.0.0 to 4.0.1 ([4e64dce](4e64dce)) * bump @libp2p/tcp from 5.0.2 to 6.0.8 ([#165](#165)) ([fb676ab](fb676ab)) * bump @multiformats/multiaddr from 11.6.1 to 12.0.0 ([#189](#189)) ([aaf7e2e](aaf7e2e)) * bump aegir from 37.12.1 to 38.1.6 ([#183](#183)) ([6725a0a](6725a0a)) * bump aegir from 38.1.8 to 39.0.1 ([#202](#202)) ([3bf4027](3bf4027)) * bump aegir from 40.0.13 to 41.1.6 ([#232](#232)) ([653c74b](653c74b)) * bump aegir from 41.3.5 to 42.2.3 ([#262](#262)) ([2bb9733](2bb9733)) * bump aegir from 42.2.11 to 44.1.0 ([#271](#271)) ([d7f85cc](d7f85cc)) * bump it-drain from 1.0.5 to 2.0.0 ([#147](#147)) ([56663f8](56663f8)) * bump it-drain from 2.0.1 to 3.0.1 ([#190](#190)) ([306bdc4](306bdc4)) * bump multiformats from 12.1.3 to 13.0.1 ([#253](#253)) ([aebd43a](aebd43a)) * bump uint8arrays from 4.0.10 to 5.0.1 ([#248](#248)) ([290bb2a](290bb2a)) * bump uint8arrays from 4.0.10 to 5.0.1 ([#263](#263)) ([b5eb311](b5eb311)) * **dev:** bump @libp2p/components from 2.1.1 to 3.0.1 ([#133](#133)) ([6d75a57](6d75a57)) * **dev:** bump @libp2p/interface-mocks from 10.0.3 to 11.0.0 ([#199](#199)) ([76f7b6f](76f7b6f)) * **dev:** bump @libp2p/interface-mocks from 4.0.3 to 6.0.0 ([#130](#130)) ([3807d1d](3807d1d)) * **dev:** bump it-all from 1.0.6 to 2.0.0 ([#148](#148)) ([1caa500](1caa500)) * **dev:** bump protons from 6.1.3 to 7.0.2 ([#179](#179)) ([07d5872](07d5872)) * **dev:** bump sinon from 14.0.2 to 15.0.1 ([#166](#166)) ([1702efb](1702efb)) * **dev:** bump sinon from 15.2.0 to 17.0.1 ([#231](#231)) ([591b464](591b464)) * **dev:** bump sinon from 17.0.2 to 18.0.0 ([#267](#267)) ([e9fb07a](e9fb07a)) * **dev:** bump sinon-ts from 0.0.2 to 1.0.0 ([#144](#144)) ([cfc8755](cfc8755)) * **dev:** bump sinon-ts from 1.0.2 to 2.0.0 ([#233](#233)) ([de13473](de13473)) * update @multiformats/multiaddr to 11.0.0 ([#128](#128)) ([885d901](885d901)) * update all it-* deps to the latest versions ([#193](#193)) ([cb0aa85](cb0aa85)) * update it-stream-types to 2.x.x ([#196](#196)) ([a09f6d5](a09f6d5)) * update libp2p to v1 ([#235](#235)) ([6f2917b](6f2917b)) * Update multiformats and related dependencies ([#170](#170)) ([06744a7](06744a7)) * update sibling dependencies ([fdfca91](fdfca91)) * update sibling dependencies ([ba4dd19](ba4dd19)) * update sibling dependencies ([db50405](db50405)) * update sibling dependencies ([e0ec5ec](e0ec5ec)) * update sibling dependencies ([775bd83](775bd83)) * update sibling dependencies ([56711c4](56711c4)) * update sibling dependencies ([c3ebd58](c3ebd58)) * update uint8arraylist and protons deps ([#115](#115)) ([34a8334](34a8334)) * update uint8arrays, protons and multiformats ([#143](#143)) ([661139c](661139c))
|
🎉 This issue has been resolved in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscribing to pubsub topics is a two step process - first we subscribe, then we receive messages.
We may subscribe and not receive messages, so change the return type to reflect that.
It now returns a promise, after which is resolved the node is subscribed, and the response has a
messagesmethod that can be used to iterate over any received messages, and acancelmethod that will cancel the subscription.BREAKING CHANGE: the return type of
client.pubsub.subscribehas changed