Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Needs more safe way to extract info from multiaddrs #44

Closed
daviddias opened this issue Jan 29, 2017 · 1 comment
Closed

Needs more safe way to extract info from multiaddrs #44

daviddias opened this issue Jan 29, 2017 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue

Comments

@daviddias
Copy link
Member

Currently this code -- https://github.com/libp2p/js-libp2p-railing/blob/master/src/index.js#L22-L29 -- is very prone to error if something weird is passed.
@daviddias daviddias added exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Jan 29, 2017
@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Feb 14, 2017
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Feb 5, 2018
@zcstarr zcstarr mentioned this issue Mar 1, 2018
Merged
@zcstarr
Copy link
Contributor

zcstarr commented Mar 1, 2018

Submitted a quick pr for this wasn't 100 on the intent lmk, if I'm off base here or had something else mind :)

@ghost ghost removed the status/ready Ready to be worked label Jun 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcstarr @daviddias