This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
fix: reconnect should trigger topology on connect if protocol stored #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
force-pushed
the
fix/reconnect-should-trigger-topology-on-connect-if-protocol-stored
branch
from
f2ab2cd
to
bcc380e
Compare
1 task
jacobheun
approved these changes
Jul 3, 2020
src/topology/multicodec-topology.js
Outdated
| return | ||
| } | ||
|
|
||
| if (this.multicodecs.filter(multicodec => protocols.includes(multicodec)).length) { |
There was a problem hiding this comment.
nit: I'd change this to a find, we don't need to go through all the multicodecs if we find one.
jacobheun
deleted the
fix/reconnect-should-trigger-topology-on-connect-if-protocol-stored
branch
|
We may want to backport this to 0.2.x for those who still need to upgrade from the peerinfo changes. |
|
On it |
|
It is not as easy as this one. Registrar does not have access to the I need to add libp2p to registrar in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering a scenario where Peer A and B start, connect to each other using a multicodec topology. Then, Peer B restarts, it is still not connected to A. It will run the update peers: https://github.com/libp2p/js-libp2p-interfaces/blob/master/src/topology/multicodec-topology.js#L68 but it does not have a connection to A yet, so it will not call onConnect. After this, identify will run, but the protocols will not change and the protocol change handler will not be called.
Fixes libp2p/js-libp2p#658