Skip to content
This repository has been archived by the owner on Jun 26, 2023. It is now read-only.

[transport] Add abort support for dialing #28

Closed
jacobheun opened this issue Dec 17, 2018 · 1 comment
Closed

[transport] Add abort support for dialing #28

jacobheun opened this issue Dec 17, 2018 · 1 comment

Comments

@jacobheun
Copy link
Contributor

In progress dials can cause terminating libp2p nodes to hang, https://github.com/libp2p/js-libp2p-switch/issues/281. Additionally, being able to abort in progress dials would help us better support future iterations of connection management and coalescing dials.

While the listener.close method should terminate existing connections, it does not handle closing out in progress dials. In the event a dial is taking a significant amount of time, due to connectivity or issue with the receiving node, applications can take a significant amount of time to shutdown gracefully.

@daviddias daviddias transferred this issue from libp2p/interface-transport Feb 5, 2020
@daviddias daviddias changed the title Add abort support for dialing [transport] Add abort support for dialing Feb 5, 2020
@jacobheun
Copy link
Contributor Author

This is done, all transports implementing the new interface (as of libp2p 0.27) have full support for dial aborting.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant