OpenStream needs to take a context

[Stebalien]

This could block on some systems that restrict the number of open streams.

[raulk]

To provide some colour on this: yamux and mplex allow unlimited streams (well, bounded by the int length of the stream index) but we're not always upgrading connections via those multiplexers.

I guess the original authors of the API go-stream-muxer API assumed that opening a stream is cheap and non-blocking. However, with transports like QUIC, where multiplexing is native, YMMV.

Ways forward

I can think of two:

1. Change the method signature in the interface, and change the mux adaptors to conform. This implies breakage.
2. Keep the interface intact and add a new interface, adapting the call sites to type cast and pass the context in accordingly.

I'd prefer 1 -- with gomod the impact should be limited.

---

Do we need to pass in a context to AcceptStream too?

[Stebalien]

Do we need to pass in a context to AcceptStream too?

Probably not. AcceptStream is an analog of Listener.Accept and can be interrupted by closing the listener.