Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quic-go removed config field causes compilation error #2739

Closed
linted opened this issue Mar 18, 2024 · 1 comment · Fixed by #2742
Closed

Quic-go removed config field causes compilation error #2739

linted opened this issue Mar 18, 2024 · 1 comment · Fixed by #2742

Comments

@linted
Copy link

linted commented Mar 18, 2024

The latest version of Quick-Go removes the RequireAddressValidation callback in the config struct. quic-go/quic-go#4253

An update will need to be made to remove this field from the quicreuse transport to avoid compilation errors.

RequireAddressValidation: func(net.Addr) bool {

# github.com/libp2p/go-libp2p/p2p/transport/quicreuse
../../../../../go/pkg/mod/github.com/libp2p/[email protected]/p2p/transport/quicreuse/config.go:15:2: unknown field RequireAddressValidation in struct literal of type quic.Config
Version Information
github.com/libp2p/go-libp2p v0.33.0
github.com/libp2p/go-libp2p-asn-util v0.4.1
github.com/libp2p/go-libp2p-testing v0.12.0
github.com/quic-go/qpack v0.4.0
github.com/quic-go/qtls-go1-20 v0.3.4
github.com/quic-go/quic-go v0.42.0
github.com/quic-go/webtransport-go v0.6.0
@Jorropo
Copy link
Contributor

Jorropo commented Mar 18, 2024

Would be fixed by #2740

@MarcoPolo MarcoPolo linked a pull request Mar 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants