Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop minio package for SHA256 with Go 1.21 #2308

Closed
marten-seemann opened this issue May 24, 2023 · 0 comments · Fixed by #2309
Closed

drop minio package for SHA256 with Go 1.21 #2308

marten-seemann opened this issue May 24, 2023 · 0 comments · Fixed by #2309
Assignees
@Jorropo
Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue status/blocked Unable to be worked further until needs are met

Comments

@marten-seemann
Copy link
Contributor

See multiformats/go-multihash#173 for context.
@marten-seemann marten-seemann added help wanted Seeking public contribution on this issue exp/novice Someone with a little familiarity can pick up status/blocked Unable to be worked further until needs are met good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels May 24, 2023
@Jorropo Jorropo self-assigned this May 24, 2023
Jorropo added a commit to Jorropo/go-libp2p that referenced this issue May 24, 2023
@Jorropo
chore: update go-multihash, drop minio sha256 for go1.21
15197f8 
Fixes: libp2p#2308
@Jorropo Jorropo mentioned this issue May 24, 2023
Merged
Jorropo added a commit to Jorropo/go-libp2p that referenced this issue May 24, 2023
@Jorropo
chore: update go-multihash, drop minio sha256 for go1.21
a18ccec 
See rational and benchmarks in multiformats/go-multihash#173.

Fixes: libp2p#2308
Jorropo added a commit to Jorropo/go-libp2p that referenced this issue Aug 16, 2023
@Jorropo
chore: update go-multihash, drop minio sha256 for go1.21
129dca1 
See rational and benchmarks in multiformats/go-multihash#173.

Fixes: libp2p#2308
Jorropo added a commit to Jorropo/go-libp2p that referenced this issue Aug 16, 2023
@Jorropo
chore: drop minio sha256 for go1.21
6e6da49 
See rational and benchmarks in multiformats/go-multihash#173.

Fixes: libp2p#2308
marten-seemann pushed a commit that referenced this issue Aug 17, 2023
@Jorropo
use standard library sha256 implementation for Go 1.21 (#2309)
e935729 
See rational and benchmarks in multiformats/go-multihash#173.

Fixes: #2308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jorropo Jorropo

Labels
effort/hours Estimated to take one or several hours exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use standard library sha256 implementation for Go 1.21 Jorropo/go-libp2p
2 participants
@marten-seemann @Jorropo