Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

identify metrics: track agent and protocol version #2182

Closed
Tracked by #1356
sukunrt opened this issue Mar 15, 2023 · 3 comments
Closed
Tracked by #1356

identify metrics: track agent and protocol version #2182

sukunrt opened this issue Mar 15, 2023 · 3 comments
Assignees
Labels
kind/discussion Topical discussion; usually not changes to codebase

Comments

@sukunrt
Copy link
Member

sukunrt commented Mar 15, 2023

Track AgentVersion and ProtocolVersion and transport used per connection.

@sukunrt sukunrt self-assigned this Mar 15, 2023
@marten-seemann
Copy link
Contributor

How do you make sure that this doesn't become an attack vector? The inputs are controlled by the attacker? Ar you planning to introduce a whitelist?

@p-shahi p-shahi mentioned this issue Mar 16, 2023
16 tasks
@p-shahi
Copy link
Member

p-shahi commented May 1, 2023

Copying

tracking agent version is a difficult since it's a user controlled field, so an attacker can generate lots of agent versions which would lead to creation of a lot of prometheus time series on our end.
@marten-seemann has some ideas around a useful construct where we allow applications to specify a regex. However we can take that up after we finish the initial set of metrics.

#2103 (comment)

@p-shahi p-shahi moved this to Discuss in go-libp2p May 22, 2023
@p-shahi p-shahi added the kind/discussion Topical discussion; usually not changes to codebase label May 22, 2023
@p-shahi
Copy link
Member

p-shahi commented May 30, 2023

closing in favor #2205

@p-shahi p-shahi closed this as completed May 30, 2023
@github-project-automation github-project-automation bot moved this from Discuss to 🎉 Done in go-libp2p May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Topical discussion; usually not changes to codebase
Projects
Status: 🎉 Done
Development

No branches or pull requests

3 participants